Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lxqt-transupdate to update translations in cmake #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agaida
Copy link
Member

@agaida agaida commented Oct 19, 2018

Removed not needed code
Removed Qt4 support
supersedes /pull/36

Removed not needed code
Removed Qt4 support
@agaida agaida changed the title Use lxqt-transupate to update translations in cmake Use lxqt-transupdate to update translations in cmake Oct 19, 2018
if (TR_UPDATE_TRANSLATIONS)
message("Running lxqt-transupdate: ")
execute_process(
COMMAND lxqt-transupdate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should change the logic of getting sources and ts files in lxqt-transupdate and use here the ${TR_SOURCES} and ${tsFiles} .... so the configuration is exactly on one place (not in CMakeLists.txt together with .translation-update)

@agaida
Copy link
Member Author

agaida commented Oct 26, 2018

@palinek - i'm not convinced - it would make sense the other way round. To be verbose of: I don't see any sense in any cmake magic here - you might see it different. But .translation-update is exactly the scheme that is used in weblate too. So please see .translation-update as a kind of documentation. Might sound crazy, but isn't - let's use .translation-update as a single point of failure. We will notice it if something goes wrong here very fast. The point is: If we change some translation directories (moving or renaming paths) this will break weblate too. So i would like it to fail in cmake too. That would be great.

@luis-pereira
Copy link
Member

@agaida Is this PR still valid ?

@stefonarch
Copy link
Member

stefonarch commented Dec 16, 2020

I think this is not a good idea anymore, it would need always committing all pending translations in weblate first.

Now always before running lxqt-transupdate it is mandatory to

  • commit and push all pending translations in weblate
  • lock the component to prevent changes

Run it, commit and merge it and only after that unlock weblate component. Otherwise there will be rebase issues in weblate,

@redtide
Copy link

redtide commented Jul 10, 2023

So please see .translation-update as a kind of documentation

FWIW I hope to see .translation-update and translations/CMakeLists.txt to go away and use only CMake automation or lxqt-transupdate as manual command. Those files are just confusing and seem also unneeded. I lost hours to try to understand how those files works, and still IDK what those are for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants